[Fix] Camera crash on deallocation #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nejcvivod
requested review from
borut-t,
EgzonArifi,
dejanskledar,
ArlindDushi and
nagavcindriqim
dejanskledar
approved these changes
Dec 10, 2024
nagavcindriqim
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deallocating the camera object after calling
stopSessioncan sometimes produce a crash; usingsyncinstead ofasyncon the queue prevents this as the object is kept around until the session actually stops :)Repro is quite simple - create a view of some kind that holds an optional reference to the camera (qrscanner in my case), calls
stopCamera()and also nils the reference at the same time. This crashes the app withEXC_BAD_ACCESSonguard self.session.isRunninginCamera.swiftApplying this patch fixes the issue :)